Repository navigation
fix(config)!: BREAKING: default optableCacheTargeting to OPTABLE_RESOLVED - #384
Open
jrosendahl-opt wants to merge 1 commit into
Open
jrosendahl-opt wants to merge 1 commit into
jrosendahl-opt wants to merge 1 commit into
Conversation
…LVED targeting() wrote its public cache copy to "optable-cache:targeting", while buildRTD, pubProvidedId and identifyAndTokenize all default to "OPTABLE_RESOLVED". With default configs RTD never saw targeting results and tokenize-resolved UID2s were not refreshable from cache. OPTABLE_RESOLVED is already the convention used by wrapper integrations; make it the default. Move the default into DCN_DEFAULTS. The uid2-refresh test for the default key read DCN_DEFAULTS.optableCacheTargeting, which did not exist, so it was testing undefined; it now checks the real default. BREAKING CHANGE: the default public targeting cache key changes from "optable-cache:targeting" to "OPTABLE_RESOLVED". Integrations reading "optable-cache:targeting" directly must set optableCacheTargeting explicitly. targeting() now overwrites OPTABLE_RESOLVED, including EIDs merged there by identifyAndTokenize. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
I do not know the versioning scheme in this package/repo, but if it is a breaking change, there should be a bump in some version number |
Contributor
Author
Yes and we should be using semver. |
antoinehakim-optable
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
targeting()wrote its public cache copy tooptable-cache:targeting, whilebuildRTD,pubProvidedIdandidentifyAndTokenizeall default toOPTABLE_RESOLVED. With default configs:targeting()results (it woke onoptable-targeting:change, then read a key nothing had written);refreshStaleUid2sFromCache(documented as a known mismatch inuid2-refresh.md).OPTABLE_RESOLVEDis already the convention used by wrapper integrations, so this makes it the default.Found while auditing the README against the code.
Notes
optable-cache:targetingfrom localStorage directly stop getting updates and must setoptableCacheTargeting: "optable-cache:targeting". Old values stay in localStorage, unused.targeting()now overwritesOPTABLE_RESOLVED, including EIDs merged there byidentifyAndTokenize. Integrations that already setoptableCacheTargeting: "OPTABLE_RESOLVED"are unaffected.