Skip to content

Fix Negative edition filter sticking when paging seeds - #7

Merged
OptimusPi merged 1 commit into
masterfrom
fix/negative-edition-stuck-filter
Nov 5, 2026
Merged

OptimusPi merged 1 commit into
masterfrom
fix/negative-edition-stuck-filter

Conversation

@OptimusPi

Copy link
Copy Markdown
Owner

RenderImagesWithCanvas set canvas.style.filter for Negative cards but never cleared it. Paging to another seed reuses the same canvas element, so the invert filter stayed on non-Negative cards. The effect also omitted invert from its dependencies.

The filter is now set to none when invert is false, and invert is in the dependency array.

Not run or typechecked.


Generated by Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KJq1K1aoRZaCh3C5D6oM9W
@greptile-apps

greptile-apps Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The change appears safe to merge and fixes the sticky Negative filter.

Summary

Fixes the Negative edition filter sticking when the same canvas shows another seed.

  • Reused card canvases match their filter to the current edition.

Reviews (1) · Last reviewed commit: "Reset canvas invert filter when card is ..." · Reviewed by Greptile

@OptimusPi
OptimusPi merged commit b3ff9aa into master Nov 5, 2026
3 checks passed
@OptimusPi
OptimusPi deleted the fix/negative-edition-stuck-filter branch November 5, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants