fix: run the CLI when reached through the bin symlink - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
cdmonandcdmon-mcpnow run when invoked through the symlinksnpm link/npm install -gcreate. The main-module guard resolves bothimport.meta.urlandprocess.argv[1]through the filesystem before comparing them, via a newisInvokedDirectly()exported for testing.docs/installation.mdmentionsnpm link.Why
Node resolves the entry point's symlinks before loading it, so
import.meta.urlnames the realdist/cli.js, whileprocess.argv[1]is the path as typed —.../node_modules/.bin/cdmon. The two never matched from an installed command, so the module loaded, ran nothing, and exited 0.cdmon --helpprinted nothing; a deploy step in CI would have reported success without doing anything. Reproduced with a symlink todist/cli.jsbefore the change, and confirmed fixed after.Checklist
npm testpassesnpm run typecheckpassesdocs/updated if behaviour changedCHANGELOG.mdupdated if the change is user-observable