Skip to content

feat: add wallet seam, discovery url params, media query hook and not found page - #174

Merged
Marvell69 merged 1 commit into
OracleDesk:developfrom
Pro-builder:feat/discovery-states-and-mobile-polish
Oct 18, 2026
Merged

Marvell69 merged 1 commit into
OracleDesk:developfrom
Pro-builder:feat/discovery-states-and-mobile-polish

Conversation

@Pro-builder

Copy link
Copy Markdown
Contributor

Closes #133
Closes #134
Closes #135
Closes #136

Wallet seam (#133)

  • WalletContext is exported from lib/stellar/WalletProvider.tsx so tests and stories can provide a fake value without loading the wallet kit.
  • lib/stellar/testing/fake-wallet.ts: fakeWallet(preset, overrides) with disconnected, connecting, connected, wrongNetwork, unauthenticated and withError presets. The signer always rejects with { code: -4, message: "User declined" }, so nothing can sign.
  • Tests in lib/stellar/testing/fake-wallet.test.ts.

Responsive groundwork (#134)

  • lib/hooks/useMediaQuery.ts: SSR safe hook built on useSyncExternalStore, returns null on the server so prerendered HTML does not mismatch.
  • Quick view close control is now a 44 px touch target (min-h-11 min-w-11).

Not found states (#135)

  • New app/not-found.tsx (static) linking back to /markets.
  • Quick view copy moved to sentence case: "Market not found", "Back to markets" (caps kept through CSS).

URL synced discovery (#136)

  • lib/markets/discovery-params.ts: parseDiscovery and serializeDiscovery for q, status, category and sort. Defaults are omitted, keys are in a stable order, unknown values fall back to defaults, status=ALL round trips, and q is trimmed to 100 chars.
  • Markets filter bar uses NETWORK_LABEL instead of the hardcoded "Stellar Testnet".
  • Tests in lib/markets/discovery-params.test.ts.

@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@Pro-builder Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vercel

vercel Bot commented Oct 18, 2026

Copy link
Copy Markdown

@Pro-builder is attempting to deploy a commit to the Marvel's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Marvell69
Marvell69 merged commit 8051567 into OracleDesk:develop Oct 18, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants