Repository navigation
[MEDIUM] — recalculateCampaignStats never decrements raisedAmount after a refund, permanently inflating the campaign total #8
Description
Activity
Hi maintainer, I would love to work on this issue. I have studied the details of the issue description and I understood the requirements. I shall deliver with qualitative feedback and promptly.
🦊 GrantFox — @iyanumajekodunmi756 has been assigned to this issue as part of the Official Campaign campaign!
Next steps:
- Open a Pull Request referencing this issue (e.g.,
Closes #8) - Your PR will be reviewed by the OrbitChainLabs maintainers
Good luck! Track your progress on GrantFox.
- Open a Pull Request referencing this issue (e.g.,
- added a commit that references this issue
on Jun 23, 2026 🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign campaign!
@iyanumajekodunmi756's PR #37 was approved and merged by @Alqku.
🏆 @iyanumajekodunmi756: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (681 total points). Track your full progress on GrantFox.
👏 Great work, @iyanumajekodunmi756! Keep contributing to OrbitChainLabs.
Severity: Medium
Type: Bug
Scope: Campaigns, Donations
Labels:
bug,help wanted,Official CampaignDescription
CampaignsService.recalculateCampaignStats(src/campaigns/campaigns.service.ts, lines ~270–286) setsraisedAmount = sum(donations where status = 'CONFIRMED'). It is invoked fromcreateDonationafter each successful confirmation.The
Donation.statusenum supportsREFUNDED(prisma/schema.prisma); when a refund flow lands, the underlying row flips fromCONFIRMEDtoREFUNDEDand is excluded from the aggregation. However, no caller ever re-runsrecalculateCampaignStatson refund, soCampaign.raisedAmountcontinues to include the refunded value. Sequential refunds will monotonically grow the discrepancy between on-chain balance and recorded total.Recommendation
CONFIRMED(REFUNDED,FAILED), re-callrecalculateCampaignStatsfrom the same code path.$transactionthat updates the status and the campaign aggregate atomically.Campaign.raisedAmountdecreases by exactly the refunded amount.