Skip to content

resources: add Beastmaster - #1151

Merged
Bing-su merged 3 commits into
OverlayPlugin:mainfrom
Bing-su:feat/bst
Sep 10, 2026
Merged

Bing-su merged 3 commits into
OverlayPlugin:mainfrom
Bing-su:feat/bst

Conversation

@Bing-su

@Bing-su Bing-su commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

@github-actions github-actions Bot added 💬ko resources /resources plugin /plugin test /test, /ui/test needs-review Awaiting review jobs /ui/jobs module raidemulator /ui/raidemulator module labels Sep 9, 2026
Comment thread resources/party.ts
Comment on lines +464 to +467
BST: {
en: 'BST',
ko: '마수',
},

@xiashtra xiashtra Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://v2.xivapi.com/api/sheet/ClassJob/43?fields=Abbreviation,Abbreviation@de,Abbreviation@ja,Abbreviation@fr,Name,Name@de,Name@ja,Name@fr

  "schema": "exdschema@2:rev:83e965d091116f895d5b17573cc5d12909a5f407",
  "version": "f5af21155b99a524",
  "row_id": 43,
  "fields": {
    "Abbreviation": "BST",
    "Abbreviation@de": "BST",
    "Abbreviation@fr": "DRE",
    "Abbreviation@ja": "BST",
    "Name": "beastmaster",
    "Name@de": "Bestienbändiger",
    "Name@fr": "dresseur",
    "Name@ja": "魔獣使い"
  }
}

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems Japanese and Chinese do not use this abbreviation, so I added 'BST' with a FIXME comment.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those translations come directly from the client data, so I'm not sure what you mean by JP using a different abbreviation.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  PCT: {
    en: 'PCT',
    de: 'PKT',
    fr: 'PIC',
    ja: 'ピクトマンサー',
    cn: '画家',
    ko: '픽토',
    tc: '繪靈',
  },

What I meant was that the abbreviations for the CJK are the ones used by the community, not the ones set in the client.

In all three regions, “PCT” is the abbreviation, and although the “NameFemale” column next to it contains the following, it does not match the current abbreviations.

# PCT
ja: ピ
ko: 픽
cn: 绘

@github-actions github-actions Bot removed the needs-review Awaiting review label Sep 9, 2026
Comment thread resources/party.ts
@github-actions github-actions Bot added 💬cn 💬de 💬ja 💬fr needs-review Awaiting review and removed needs-review Awaiting review labels Sep 9, 2026
@Bing-su
Bing-su merged commit b228a6f into OverlayPlugin:main Sep 10, 2026
16 checks passed
github-actions Bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Sep 10, 2026
@Bing-su
Bing-su deleted the feat/bst branch September 11, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💬cn 💬de 💬fr 💬ja jobs /ui/jobs module 💬ko plugin /plugin raidemulator /ui/raidemulator module resources /resources test /test, /ui/test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants