Repository navigation
Documentar 201 en POST y 204 en DELETE de /api/notes - #5
Merged
Merged
Conversation
springdoc infería 200 para ResponseEntity; @ResponseStatus alinea la spec OpenAPI y el cliente Hey API con los códigos reales. Co-authored-by: Ariel Alvarado <Overrid3CL@users.noreply.github.com>
node:26 ya no incluye corepack, así que la imagen y el CI usan npm install -g. El workflow de frontend y del cliente OpenAPI pasa a Node 26, igual que el Dockerfile. Co-authored-by: Ariel Alvarado <Overrid3CL@users.noreply.github.com>
…us-d02e Trae main (Node 26) y el arreglo de pnpm sin corepack mientras el PR #7 no está mergeado. Co-authored-by: Ariel Alvarado <Overrid3CL@users.noreply.github.com>
Overrid3CL
marked this pull request as ready for review
October 2, 2026 15:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen
La spec de springdoc documentaba
POST /api/notesyDELETE /api/notes/{id}como 200, aunque el runtime ya devolvía 201 Created y 204 No Content.@ResponseStatusenNoteControllerhace que la spec publique 201 con el body de la nota creada y 204 sin body, sin dejar un 200 sobrante. El snapshotfrontend/openapi/openapi.jsony el cliente Hey API se regeneraron a partir de ese contrato.Closes #4
Spec
POST /api/notes:200OK +NoteResponse→201Created +NoteResponseDELETE /api/notes/{id}:200OK →204No Content (sin body)Pruebas locales
./gradlew testen verde.pnpm lint,pnpm typecheckypnpm testen verde.