Repository navigation
Separate integrity (DPP-SEC-002) from the issuer check (DPP-SEC-013) - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapts the proof check to dpp-criteria 5ee9043. Without key_from (DPP-SEC-002) every proof found is verified with the key it names (Data Integrity verificationMethod, JWS kid, payloadHash of the passport DID). With key_from (DPP-SEC-013, SHOULD) at least one verified proof has to be issued with a key of the economic operator, otherwise the result is a warning. didlint answers are cached per validation. Fixes the two failing tests in validations_test.rb on main.