Repository navigation
Add CFMIP4 data - #478
Add CFMIP4 data#478znichollscr wants to merge 7 commits into
Conversation
|
@daianzhuo sorry I've been so slow on this. Picking up now. I've had a very quick look at your data. This is going to take a few iterations to get right. To help guide the next step, can you please tell me:
|
|
@znichollscr thanks for looking into this.
|
Ok. You can do it based on this logic if you wish. You don't have to split this way though (see more below).
Very little: it's just a note (but we can't get around it anyway, so not worth worrying about it)
Ok this simplifies things. For the
For the Then the question is what to put in this 'middle-bit'. Here there are a few options I could think of quickly:
|
|
Thanks @znichollscr, all sounds good! For the middle bit, let's follow option 1 with one tweak. For the amip-piForcing dataset, I would use the following source ID: |
|
Ok thank you. I have just pushed those updated source IDs. Next step, we need to rewrite the files. I have put a commented ncdump below which will hopefully give you the guidance you need. You don't need to rename the files yet, I'll explain that in the next step If you can send me (or upload into the google drive link I shared via email) a single AMIP file and a single piClim-deltaSST, that will be enough for checking, no need to send the full set at the moment |
|
Thanks. I've now uploaded two sample files to the Google Drive. I used the source IDs we agreed on. While editing the attributes, I realised that one tweak needs to be made to the CVs: for the AMIP datasets, Jonathan Gregory should be removed from the list of contacts (but he should be included in the piClim-deltaSST files). I'm not GitHub-savvy so I wasn't sure whether I could make this edit myself? |
|
Thanks
You can if you want (google something like "GitHub edit file in browser and make pull request"), but you don't need to: this change is tiny and I can do it. I hope to have a more in depth look at the files early next week |
|
Alrighty @pceppi sorry I have been so slow replying. Tweaks for the next round
|
|
Thanks @znichollscr. For the Also, for |
|
Apologies I meant to link https://input4mips-validation.readthedocs.io/en/latest/api/input4mips_validation/database/raw/#input4mips_validation.database.raw.Input4MIPsDatabaseEntryFileRaw.tracking_id import uuid # part of the standard library
tracking_id = f"hdl:21.14100/{uuid.uuid4()}" |
Not that I am aware of, but you are free to change them if you wish |
|
Thanks @znichollscr, have now updated the files accordingly. An additional minor tweak (not requested by you) is that I removed the _FillValue attributes from the |
Description
Checklist
Please confirm that this pull request has done the following:
changelog/