fix(unified): make tray quit non-blocking and stop every sidecar descendant - #148
Merged
Merged
Conversation
…endant Signed-off-by: Tim Nunamaker <tnunamak@gmail.com> Assisted-by: AI
Signed-off-by: Tim Nunamaker <tnunamak@gmail.com> Assisted-by: AI
Contributor
Author
|
Folded into #141. Assisted-by: AI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tray Quit or an external
SIGTERMcould leave the unified reference implementation and console sidecars, including descendants, running after DataConnect terminated.The first fix routes
RunEvent::ExitRequestedthrough one background shutdown path, prevents the first exit request, stops both sidecars concurrently under a ten-second budget, and callsapp.exitonly after cleanup. The follow-up finding was that a default external signal terminates the Rust process before Tauri reachesRunEvent::ExitRequestedorRunEvent::Exit; the supervisor now registers active POSIX process-group IDs and a signal-handling thread sendsSIGKILLto every registered process group before restoring default signal termination. The normal menu path keeps its bounded graceful-signal, polling, and force-kill sequence.Evidence: the Unix parent-signal test starts a grouped sidecar plus descendant, sends
SIGTERMto the helper parent, and verifies both processes die; the supervisor suite passes 9/9 runnable tests with one helper ignored, and the unified suite passes 7/7. Fullcargo test --all-targetsreports 200 passed, 34 failed, and 4 ignored; I did not resolve those failures because they match this checkout's known missing packaged connector/runtime artifacts, includingp-queueandpatchright. Remaining uncertainty: clippy is still blocked by pre-existing errors insrc/commands/oci.rs, and GUI quit behavior was not manually verified because the task brief forbids launching the app.Assisted-by: AI