feat(docker): source connectors from the runtime catalog - #152
Merged
tnunamak merged 1 commit intoSep 16, 2026
Merged
Conversation
Keep production Docker images independent of the devendored polyfill connector package while preserving host conformance coverage. Declare its transitive runtime dependencies directly and route optional helpers through a fail-closed boundary so catalog installs and preloaded digest roots remain the executable connector path. Signed-off-by: Tim Nunamaker <tnunamak@gmail.com> Assisted-by: AI
Contributor
Author
|
Folded into #141. Assisted-by: AI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy/docker/Dockerfile:32-60made every production image copypdpp-polyfill-connectors-0.0.1.tgz, and:117-132derived Patchright from that tarball; this coupled first boot to the devendored package instead of letting the active catalog/install roots supply executable connectors. The RI also imported polyfill helpers directly across runtime paths, so removing the tarball would fail startup rather than produce an empty, catalog-backed no-install state.This patch keeps the reference-contract tarball, removes the connector tarball from the production context and
--omit=devinstall, declares the transitive runtime packages directly, and pins browser setup to RI's direct Patchright dependency.server/polyfill-connectors-runtime.tsprovides the optional host/conformance boundary with empty and fail-closed production fallbacks.PDPP_CONNECTOR_PRELOAD_DIRselects the file-backed install roots for air-gapped connector activation.Evidence:
@pdpp/polyfill-connectorsor its tarball.Not verified: a live authenticated GHCR catalog read; the owner catalog path is covered by the fixture test and container auth boundary. Existing RI typecheck and repo-wide check noise remains documented in the report.
Assisted-by: AI