chore(deps): weekly security sweep, patch all open Dependabot alerts (wk 3) - #128
Merged
Merged
Conversation
Resolve every open Dependabot alert on the root and Astro template lockfiles, plus the vitest advisory on the other templates, and fix the inaccuracies found in the docs pass. Closes #116. Root workspace (pnpm update -r --depth Infinity, 7-day release cooldown): js-yaml 4.3.2, fast-uri 3.1.7, brace-expansion 1.1.18 / 5.0.9, browserslist 4.28.9, baseline-browser-mapping 2.11.21, nanoid 3.3.18, postcss 8.5.28, @humanfs/node 0.16.8, @babel/core 7.29.7. All within existing ranges, no new overrides needed; the qs override is kept. pnpm audit: 34 findings on main, 0 after. templates/astro: lockfile was stale (astro 6.4.8 against ^7.2.8) so it is regenerated: astro 7.3.1, esbuild 0.28.2, sharp 0.35.4, smol-toml 1.8.0, svgo 4.1.0, undici 7.29.1, js-yaml 4.3.2, vitest 4.1.11. @testing-library/jest-dom narrowed to ~6.9.1 in all templates because 6.10.0 is deprecated upstream as a breaking minor. templates/{vite,nextjs,vue,sveltekit}: vitest and @vitest/coverage-v8 ^3.0.0 -> ^4.1.11 (GHSA-82fw-gwwq-j7x9); their vitest configs use no removed options. Docs: README quick start said `cd app` but setup-project.sh creates the directory named after the project; quickstart pinned pnpm@latest, which would drop the overrides section from the lockfile under pnpm 12; onboarding prerequisites now say Node 22.13+ and pnpm 10.x. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #116.
The issue named three alerts, but by now there were ~50 open Dependabot alerts across the root lockfile, the Astro template lockfile, and the other templates' manifests. This PR remediates all of them with in-range updates. No new
pnpm.overrideswere needed: every patched version fits its parent's declared range, including the three called out in the issue (js-yaml, @babel/core, esbuild).Release-age guard
No
minimumReleaseAgeis configured in this repo, so I applied a 7-day cooldown by hand via pnpm'sminimum-release-agesetting during resolution (e.g. it chose nanoid 3.3.18 from Aug 7 over 3.3.19 from Sep 10). If the org standard is a different window, say so and I will re-resolve.Root workspace
pnpm update -r --depth Infinitywith pnpm 10 (the version that wrote the current lockfile). Ranges inpackage.jsonwere raised by the same command; every bump stays within its current major.pnpm audit --audit-level moderate(the CI security job): 34 findings on main → 0. Theqsoverride is preserved.templates/astro
Its lockfile was stale (astro 6.4.8 resolved against a
^7.2.8manifest after #124/#125 bumped only the manifest), so it is regenerated from scratch with the same cooldown: astro 7.3.1, esbuild 0.28.2, sharp 0.35.4, smol-toml 1.8.0, svgo 4.1.0, browserslist 4.28.9, undici 7.29.1, js-yaml 4.3.2, vitest 4.1.11.astro buildpasses.@testing-library/jest-domis narrowed to~6.9.1(6.10.0 is deprecated upstream as an accidental breaking minor); applied to the vite and nextjs templates too.templates/{vite,nextjs,vue,sveltekit}
vitestand@vitest/coverage-v8^3.0.0→^4.1.11(#94–#97). Their vitest config templates use onlyglobals,environment,setupFiles,include,exclude, andcoverage.{provider,reporter,exclude,thresholds}, none of which changed in vitest 4. Each manifest resolves cleanly with vite 6/7.Docs accuracy pass
cd app, butsetup-project.shcreates a directory named after the project. Fixed here and in the onboarding quickstart.pnpm@latest. pnpm 12 ignorespnpm.overridesin package.json and would silently drop the override section from the lockfile (the failure mode behind chore(deps): bump pdfjs-dist from 6.0.227 to 6.2.108 #120/chore(deps-dev): bump vitest from 4.1.2 to 4.1.11 #126). Now pins 10.34.5, matching build: pin pnpm 10 via packageManager so Dependabot and CI agree #127.check-doc-counts.shpasses. The GitHub repo description still said 53; I updated it to 56 viagh repo edit.pnpm install --frozen-lockfilepasses under both pnpm 9 (CI) and pnpm 10.Verification
lint-and-format.sh --check,check-doc-counts.sh,validate-pipeline-config.jsall pass.pnpm install --frozen-lockfileunder pnpm 9.15.9 and 10.34.5.Not done / follow-ups
🤖 Generated with Claude Code