Repository navigation
fix: constrain the 3.10 fork of onnxruntime to a release with cp310 wheels (#281) - #282
Merged
Merged
Conversation
…heels (#281) uv.lock forked onnxruntime by interpreter and selected 1.24.3 for python_full_version < '3.11' — a release whose metadata still admits 3.10 but which publishes wheels only for cp311+ and no sdist. uv resolves on metadata, not wheel availability, so the documented contributor path (uv sync --frozen --extra ml) exited 2 on 3.10, the lowest interpreter requires-python names, while 3.11 and 3.12 were fine. pip on 3.10 was never affected: it selects by wheel and lands on 1.23.2. - pyproject gains [tool.uv] constraint-dependencies pinning the < 3.11 fork to onnxruntime < 1.24; the re-lock selects 1.23.2 (the last release with cp310 wheels) for that branch and leaves the >= 3.11 branch on 1.27.0. The three added lock entries (coloredlogs, humanfriendly, pyreadline3) are 1.23.2's own dependencies. - The CI test matrix gains a `uv sync --frozen --all-extras --dry-run` step per interpreter: the [ml] install itself stays on the macOS job (the Linux lock pulls the CUDA torch stack), but resolution and wheel availability are now checked on 3.10/3.11/3.12, the coverage gap the issue names. Smoke-tested: the ml and all-extras dry-runs pass on 3.10/3.11/3.12 and the dev control still passes; the same dry-run against the old lock reproduces the issue's exact error, so the new CI step catches this class of drift; onnxruntime 1.23.2 installs and imports on a real cp310 interpreter; uv lock --check is clean. Fixes #281
…p310-lock # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #281 —
uv sync --frozen --extra mlexited 2 on CPython 3.10 because the lock'spython_full_version < '3.11'fork selectedonnxruntime==1.24.3, whose metadata still admits 3.10 but which publishes wheels only for cp311+ (and no sdist). uv resolves on metadata rather than wheel availability, so the lock was uninstallable on the lowest interpreterrequires-pythonnames. The PyPI/pip path was never affected — pip selects by wheel and lands on 1.23.2.Changes
pyproject.toml: new[tool.uv] constraint-dependenciesentry pinning the< '3.11'fork toonnxruntime<1.24, with a comment explaining why. The runtime requirement (>=1.10.0) is untouched.uv.lock: re-locked — the < 3.11 branch moves to 1.23.2 (the last release with cp310 wheels), the ≥ 3.11 branch stays on 1.27.0. The three added packages (coloredlogs,humanfriendly,pyreadline3) are 1.23.2's own dependencies.CI coverage gap (needs a maintainer push)
The issue's coverage note is right:
--extra mlis only ever synced under a pinned 3.12, so nothing exercised the 3.10 resolution. The fix for that is one step in theci.ymltest matrix, but pushing workflow changes needs an OAuth token with theworkflowscope, which this push lacked. The step to add after "Install frozen environment":Verified locally: this command passes on 3.10/3.11/3.12 with the new lock and reproduces the issue's exact error against the old one.
Smoke tests
uv sync --frozen --extra ml --dry-runpasses on 3.10, 3.11, and 3.12; the--extra devcontrol on 3.10 still passes;--all-extras --dry-runpasses on all three.onnxruntime (v1.24.3) only has wheels with ... cp311, cp312).onnxruntime==1.23.2installs and imports on an actual CPython 3.10 venv.uv lock --checkclean; unit test sanity subset passes (29 tests).