Repository navigation
i18n(client): translate the last readable English on the client screens, the public header and the mass email - #191
Merged
Conversation
Panelica
pushed a commit
that referenced
this pull request
Oct 15, 2026
The stored card's last digits ("terminada en", as card_expiring already
says), the two-factor QR code's text, an announcement's date and time, the
"Soon" badge, the CSR field's hint and the mass email's greeting ("Hola
:name,", as email_verify.mail_greeting in the same file). Spanish has every
client text again.
Owner
|
Thank you, Ertuğrul. What a customer reads now goes through translations, down to the stored card's last digits and the mass email's greeting, with names, dates and digits as placeholders so each language can order them its own way. Merged with one commit on top (19aab83, merge 71f62ae): the six new texts in Spanish, in the words the Spanish file already uses ("terminada en" for a card, "Hola :name," for a greeting). It goes out with the next beta. |
Panelica
pushed a commit
that referenced
this pull request
Oct 15, 2026
One command on a fresh server (install.sh), the release package installed without a command line, the wizard's database step tried before it is saved and run in short requests, the cron line on the finish page, the wizard in five languages (#192) and the last client texts translated (#191), the My Account language hint and the README's Docker quick start on image 1.5. No database change. A MINOR beta: features landed after 1.5.1-beta.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
After #175 and #184 for the admin area, this goes through what
HardcodedViewTextTeststill counts in the client area, the public pages and the emails.Whatever a customer actually reads now goes through translations. The ledger goes from 38 to 32 for the client area, and from 25 to 23 for the sections and emails.
What is left should stay as written:
you@example.com,yourdomain.com,shopuserandpublic_html;MB,GB,SSL,IMAP,FTP / FTPS (TLS),STARTTLSandNS;-----BEGIN/END CERTIFICATE REQUEST-----lines;Translated, in three groups:
client.payment_methods.card_ending);client.auth.qr_code_alt);client.announcements.date_at_time), so each language orders and joins them its own way;client.services.tool_soon);client.ssl.csr_paste_here).client.toggle_dark_mode;client.marketing.mail_greeting), next to themarketing.mail_footit already uses.New keys: each is written in en, tr, de, pl and zh, with names, dates and digits passed as placeholders.
How
HardcodedViewTextTestledger numbers.__().Tests
HardcodedViewTextTest: passes with the lower ledger.TranslationParityTest,DynamicTranslationParityTestandTranslationCoverageTest: pass. Every new key is in all five languages and none shadows an existing one.Full suite: 4199 passed. The one failure is the
CurrencyAndBackupTestdb backup test, which fails onmaintoo in my local setup.