[ertugrulkeyvan]

What

Found on a fresh 1.5.0 install from install.sh (Rocky Linux 9, also true on main): the first save of Setup -> General turns off all outgoing email, and the test email button still says the email was sent.

1. The checkbox and the mailer disagree. SuppressMailWhenDisabled treats an unset MailEnabled as on, so a fresh install sends mail. The settings page ticks "Enable outgoing emails" only when the value is '1'. On a fresh install the box therefore looks off. Saving the page for any other field (company name, address) posts the hidden 0, and from then on every invoice, reminder, order confirmation and password reset is cancelled. The only trace is an info line in the log: "Outgoing mail suppressed".
2. The test button hides it. Mail::raw() returns null when a MessageSending listener cancels the send, and the button reported that as "Test email sent".

On the test server: fresh install, wizard, saved the General page once with the mail fields only, pressed the test button. The answer was "sent (via sendmail)"; Postfix never saw a message, and settings.MailEnabled was 0.

How

• One reading of the switch: SuppressMailWhenDisabled::isOn() holds the rule the listener already used (empty means on; 0, false, off, no mean off). The listener and the checkbox both use it.
• The test button: when the send was cancelled, it answers success: false with "outgoing email is turned off on this page", or "a mail hook cancelled it" when the switch is on and something else stopped it. Two new keys, admin.settings.test_email_mail_off and admin.settings.test_email_cancelled, in en, tr, de, pl and zh.
• Existing installations: a stored 0 is left alone, since it may be a deliberate choice. Those operators now see the box unticked, which is what their mail is doing, and the test button tells them.

Tests

tests/Feature/MailEnabledSwitchTest.php, four new tests (seven cases); three fail on main and pass here:

• a never-set switch is drawn ticked;
• the switch is drawn from the stored value: 1 and true ticked, 0 and false not;
• the test button reports a cancelled send instead of "sent", and nothing is delivered;
• the test button still reports a test email that went out.

Full suite: 4229 passed. The one failure is the CurrencyAndBackupTest db backup test, which fails on main too in my local setup.

[Panelica]

Thank you @ertugrulkeyvan, merged in 77d59ff. A silent "every email off" after the first save of the settings page is exactly the kind of thing that is hard to notice until invoices stop arriving, so this is a valuable find.

What we checked:

• Of your new tests, three fail on main (the never-set switch drawn ticked, true drawn ticked, the test button reporting a cancelled send) and all twelve in MailEnabledSwitchTest pass with your change.
• MailEnabled is read only by the listener, the settings page and the test button, and all three now go through SuppressMailWhenDisabled::isOn(). A stored 0 stays as it is.
• On top of it we added 76ee07d: the two new messages in Spanish, which we keep at 100%.

Full suite on the merged branch (with #195): 4230 passed, 3 skipped, 0 failed. The CurrencyAndBackupTest failure did not occur here.

This will be part of the next release.