Make e-ink a responsive theme and disable UI motion - #24
Merged
Conversation
…ge dependencies in pubspec.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selecting e-ink previously forced mobile navigation even on large screens. E-ink now behaves as a theme: the current route and screen-width layout stay intact, while controls use stronger monochrome contrast and borders.
Testing
Completed locally:
flutter test --no-pub: 1,145 passed, 10 skipped.flutter analyze --no-pub: no issues.flutter build web --release --no-pub: succeeded.git diff --check: passed.Regression coverage includes layouts at 390, 850, and 1440 pixels; theme changes during animations; overlays; date and range selection; drawers; rendered toggle states; repeated keyboard interaction; and pixel comparisons of input focus/blur.
To review manually, switch between light, dark, and e-ink at phone and desktop widths. Check that navigation stays in place, then open dialogs/drawers, edit dates, toggle controls, and focus/blur text fields. Confirm e-ink transitions snap while light/dark still animate.
UI evidence
No screenshots attached. Automated layout and rendered-pixel checks are included in
app/test/themes/andapp/test/widgets/.Compatibility and migration
No data migrations or dependency changes. Existing theme preferences remain supported.
Notes
See
app/docs/eink-theme.mdfor the shared motion helpers and conventions for future UI additions.Checklist