Repository navigation
Use AES from pycryptodome package - #623
Closed
sylvainpelissier wants to merge 1 commit into
Closed
sylvainpelissier wants to merge 1 commit into
sylvainpelissier wants to merge 1 commit into
Conversation
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| """Encrypt, 0xEE-padding the key to 32 bytes and | ||
| the plaintext to a whole number of blocks. | ||
| """ | ||
| c = AES.new(key.ljust(32, bytes([PAD])), AES.MODE_ECB) |
| return bytes(dtxt) | ||
|
|
||
| """Decrypt whole 16-byte blocks; a trailing partial block is ignored.""" | ||
| c = AES.new(key.ljust(32, bytes([PAD])), AES.MODE_ECB) |
Collaborator
|
Thank you for the idea and for putting this together! I agree with replacing the custom AES implementation, but I preferred using the cryptography library instead. The alternative is implemented in #624, so I am closing this PR as superseded. |
Contributor
Author
|
Indeed, it is even better, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using pycryptodome AES implementation allows to have hardware optimizations when available and make the code easier to understand.