Skip to content

fix: validate product UUID path parameters #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orebams wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate product UUID path parameters #644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/policy/policy.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
Sse,
MessageEvent,
Param,
ParseUUIDPipe,
Query,
Body,
HttpCode,
Expand Down Expand Up @@ -377,7 +378,7 @@ export class PolicyController {
},
})
@ApiErrorResponse(404, 'No product found for the given ID.', undefined, 'Product not found')
async updateProduct(@Param('id') id: string, @Body() dto: UpdateProductDto) {
async updateProduct(@Param('id', new ParseUUIDPipe()) id: string, @Body() dto: UpdateProductDto) {
const product = await this.policy.updateProduct(id, dto);
return { success: true, data: product };
}
Expand All @@ -400,7 +401,7 @@ export class PolicyController {
},
})
@ApiErrorResponse(404, 'No product found for the given ID.', undefined, 'Product not found')
async deactivateProduct(@Param('id') id: string) {
async deactivateProduct(@Param('id', new ParseUUIDPipe()) id: string) {
const product = await this.policy.deactivateProduct(id);
return { success: true, data: product };
}
Expand Down