Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@sowunmirapheal2-max Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
@Parcel-Protocol maintainers: could you please review PR #298, approve the pending CI workflow run, and merge if the checks and repository requirements are satisfied? GitHub currently reports |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carry a worker job's correlation ID through Soroban JSON-RPC request IDs and
soroban.rpctelemetry. Generate a correlation UUID for standalone calls, and preserve failure/success records and RPC envelopes. Adds regression coverage for retries and transport failures and documents operational behavior.Scope proof
Issue: Closes #246
Feature directory: N/A - focused cross-cutting core infrastructure change, not a UI feature slice.
Changed file count: 4
git diff --name-only origin/main...HEAD | wc -lHow to Test
Run
npm test -- --run core/rpc/__tests__/client.test.ts core/workers/__tests__/queue.test.ts(30 tests pass) andnpm run verify:telemetry(passes). The focused test verifies a worker correlation ID appears as the JSON-RPC ID and in telemetry on success and transport failure, and remains the same across a worker retry. Network: Soroban RPC testnet/default configured endpoint; tests stub fetch and do not make live network requests.Validation failure: return a malformed JSON-RPC envelope and confirm it remains a failure response with the correlated ID. Transport failure: reject fetch and confirm the failure telemetry retains the ID. These are exercised by the RPC test suite.
context.correlationIdtosorobanRpc.Evidence
Screenshots: not applicable to this headless core infrastructure change. Slice-specific
npm run verify:features -- <slug>is not applicable because this is not a feature slice.npm run verify:telemetry: passed.npm run check: failed during repository-wide lint (21 errors, 84 warnings, including a parse error in untouchedcore/__tests__/registryManifestValidation.test.ts).tsc --noEmit: also reports parse errors in that untouched test file.Checklist
npm run checkpasses locallyResult<T, Code>for every expected failurecopy.tsBigInt, never floating pointREADME.mdrecords the feature's non-obvious technical decisiondocs/FEATURE_CONTRACT.md, it adds or supersedes an ADR indocs/adr/Follow-Up
This is a focused infrastructure change and intentionally does not satisfy the template's 20-file feature-slice scope. The PR requires review of this scope exception and resolution of the existing full-check failures before merge. No screenshots are relevant for this headless change.