Repository navigation
Add example of limiting particle timestep by local cfl in schism tuto… - #3016
Open
fluidnumericsJoe wants to merge 2 commits into
Open
fluidnumericsJoe wants to merge 2 commits into
fluidnumericsJoe wants to merge 2 commits into
Conversation
fluidnumericsJoe
requested review from
erikvansebille and
wyatt-fluidnumerics
October 27, 2026 19:53
for more information, see https://pre-commit.ci
erikvansebille
requested changes
Oct 28, 2026
erikvansebille
left a comment
Member
There was a problem hiding this comment.
Thanks for adding this extra context, @fluidnumericsJoe! Below a few small comments (I can't put comments directly on the notebook in GitHub)
- Is "altitude" the right word in the comment of cell [5]? That to me suggests (3D) height?
- Avoid variable names like
h,eandpin that same cell - make them more explicit so users understand what's going on? - CFL number hasn't been introduced in cell [5]. Could you move that whole cell down to the section of cell [9]? That will also make it easier to refer to this part of the tutorial directly, because all information is in one subsection
- Make explicit that the math symbol
$C$ is the same asCFL_target - Should we add a link to the CFL-section on the
tutorial_dt_integratorstoo?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an example of limiting particle timestep by local cfl in schism tutorial
Checklist
mainfor normal development,v3-supportfor v3 support)