Remove error messages from the event log - #5886
Open
rbev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the event log entry for individual message failures from both the codebase and tests. Instead, failed messages are now only visible on the failed messages screen, not in the event log. This change reduces write and retention overhead on the event log's hot ingest path and simplifies related test logic.
Event log and message failure handling:
docs/eventlog-design.mdto clarify that message failures are no longer recorded in the event log, but are instead visible only on the failed messages screen.MessageFailedDefinitionclass and its registration, which previously mapped message failure events to event log entries. [1] [2]Test cleanup and simplification:
Should_add_an_event_log_itemfromWhen_a_message_has_failed.cs, which checked for event log entries related to message failures.When_hosting_error_ingestion_only.csthat waited for message failure event log entries, as these entries are no longer created. [1] [2]