Repository navigation
Add the workshop to the website sitemap - #161
Merged
Merged
Conversation
8 of 16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The website's
sitemap.xmldoesn't list the workshop, because the workflow copies the workshop intodocs/after pkgdown has written the sitemap. A new step rebuilds the sitemap once the workshop is in place, so it also listsworkshop/,workshop/conceptual/andworkshop/applied/.The step calls
pkgdown:::build_sitemap(), which pkgdown doesn't export. If a pkgdown update removes it, the step fails and the site isn't deployed, so the problem shows up right away. The alternative is to append the three URLs tositemap.xmlwithsed, with the site URL written out.Tested locally with pkgdown 2.2.1 on a mock
docs/folder. After merging, check the live sitemap and tick the sitemap step in #23.