Skip to content

Add drop-restricted delve and incursion mods to crafting and trader - #10249

Open
vaisest wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
vaisest:drop-only
Open

Add drop-restricted delve and incursion mods to crafting and trader#10249
vaisest wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
vaisest:drop-only

Conversation

@vaisest

@vaisest vaisest commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Fixes #10246 . fix #6603, fix #5889, fix #8238, fix #8482, and probably more that I can't find.

Description of the problem being solved:

This adds drop-restricted mods to the custom modifier menu, and also adds them to QueryMods.lua. This was done by taking the incursion mod item type list from the wiki, and by manually checking delve mods on the trade site (with some missing, but they should be mostly correct).

I also renamed the original delve category to "fossil".

Legacy mods are NOT included in this PR. There were also some mods that I couldn't find on the trade site, and that might either mean the wiki page is wrong, or I messed up.

I also moved all delve mods to their own file as only half of them were there. Mods were re-exported and naturally the statorders caused 40k changed lines

054b2b5 also fixed a crash in the essence menu for fishing rods. This PR added a test build of each mod list to filter out empty ones which exposed the issue

Steps taken to verify a working solution:

  • Relevant modifiers exist in menu
  • Sorting and adding works
  • They don't show up if they have no matching entries
  • Trader generates weights for e.g. conversion mods
  • Querymods generation works fine
  • Base type names should match PoB. The wiki had some slightly different names, but I manually fixed them to be the same as PoB

Link to a build that showcases this PR:

Uses conversion gloves: https://poe.ninja/poe1/builds/allflame/character/NikitankBombas2003-6127/Ytnjcz_TTV?i=1&search=items%3DRare%2BGloves%26itemmods-Gloves%3D%2523%2525%2Bof%2BPhysical%2BDamage%2BConverted%2Bto%2BCold%2BDamage

Before screenshot:

N/A

After screenshot:

image image image image

@vaisest
vaisest marked this pull request as ready for review August 19, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant