fix: preserve explicit null endTime through seek pipeline - #232
Merged
Conversation
payload.endTime ?? undefined collapsed an explicit null into undefined before reaching seek(), so an explicit clear couldn't be told apart from the field being omitted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
seek()now acceptsendTime: number | nullinstead of justnumberacrossplayerManager.ts,player.tsand both PATCH handlers (sessions.id.groups.ts,sessions.id.players.ts). also stopped collapsingpayload.endTimethrough?? undefinedbefore it reachesseek()Why
payload.endTime ?? undefinedturned an explicitendTime: nullintoundefinedbefore it reachedseek(), soendTime !== undefined ? endTime : this.track.endTimecouldn't tell "clear the end time" apart from "field omitted", silently keeping the old end time instead of clearing itCheckmarks
Additional information
tsc passes. fun fact: lavalink has the same issue, lines here