Repository navigation
fix(web): four retro-review findings on #2063, #2067 and #2072 (TASK-3599) - #2078
Merged
Merged
Conversation
xarmian
added a commit
that referenced
this pull request
Oct 11, 2026
…UG-3602) (#2081) #2078's Go (PostgreSQL) job failed before any test ran: pulling public.ecr.aws/docker/library/postgres:17-alpine answered "toomanyrequests: Data limit exceeded". AWS's public mirror replaced Docker Hub on day 90 for the same reason (#1989), and now meters too. Every PR's PG job is exposed. The service image is now Google's Docker Hub mirror, pinned to postgres:17-alpine's multi-arch index digest (sha256:b0f9560a...552b24). That digest is the same on mirror.gcr.io and public.ecr.aws today, so it is the image CI already ran, and a moved tag cannot change it mid-flight. Claude-Session: https://claude.ai/code/session_01FAVXA5mJ5BNhKmv95jxQkQ
…3599) From the lead's retroactive Codex rounds. Each was reproduced with a test that fails on the original code before it was fixed. 1. #2063, command palette: a load-more that failed after the query or workspace changed set "Couldn't load more" on the new query. The failure now takes the same scope check as the success path. 2. #2067, quick-capture sheet: clearing compared trimmed text, so the same text typed again while the create was in flight was cleared. An input version bumped by every keystroke now decides. 3. #2067, sheet and sidebar: the item was created in the workspace captured before the await, but the toast link used the reactive prefix after it, so a switch mid-create pointed the link elsewhere. The prefix is captured with the slug. 4. #2072, collection filter summary: relation values resolved with an unrestricted id-or-slug lookup, so a legacy slug or a same-id row in another collection could be named as the value. relationSummaryLabel uses the filter chip's own resolver (relationChipFor + narrowRelationRow). budget would mean threading testInfo through every call site, and the lead's disposition was "only if trivial". Claude-Session: https://claude.ai/code/session_01FAVXA5mJ5BNhKmv95jxQkQ
xarmian
force-pushed
the
wren/task-3599-retro-fixes
branch
from
October 11, 2026 23:14
e9596ff to
23e38df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TASK-3599: findings from the lead's retroactive Codex rounds on #2063, #2067 and #2072. Each claim was reproduced first, with a test that fails on the original code and passes on the fix.
scopeMoved) as the success path.relationSummaryLabelnow uses the filter chip's own resolver (relationChipFor+narrowRelationRow).testInfothrough every call site, and the lead's disposition was "only if trivial".Evidence:
QuickCaptureSheetandSidebar: 33 tests pass.filterSummary: 10 pass. PalettesearchFailed: 6 pass.https://claude.ai/code/session_01FAVXA5mJ5BNhKmv95jxQkQ