Repository navigation
docs(changelog): backfill fragment for deferred async destroy ordering - #13536
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A queued async-resource
destroyis held until the enclosing execution scopes have emitted theirafterhook — but only for the resources those scopes own.drain_gc_destroy_queueretains the entries whose serial is still on the execution stack (plus those whose async job domain is not eligible yet) and delivers the rest, so ready resources unrelated to the active scope are not stuck behind it.That fix landed directly on
mainas9e1ec80e77on 2026-10-18. It touchescrates/, but nochangelog.d/fragment came with it, so the behavior never reached the release notes. This PR is that backfill: one fragment, no code change, no behavior change.The same bug was carried as a PR, #11761, now closed as superseded: its version returned from
drain_gc_destroy_queuewhenever any scope was active, which also held back unrelated ready resources and made all destroy delivery depend on the execution stack always unwinding to empty. What is onmainretains selectively instead, and pins the ordering with the node-suite casetest-parity/node-suite/async_hooks/hooks/interval-cancel-checkpoint-lifecycle.ts(an interval clearing itself inside its own callback, observed fromprocess.nextTickandqueueMicrotaskin that same scope).No version bump: this is a
changelog.d/-only change, matching how the previous fragment-numbering commits landed.