Repository navigation
check_file_size: allowlist snap_census/runner.rs (main's gate fails without it) - #14347
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main fails its own file-size gate.
crates/perry-runtime/src/snap_census/runner.rscame in with #13935, at 3572 code lines and with no exemption. This adds the exemption at its exact count.The split is the right end state. Open PR #14259 edits this file, so splitting it now would conflict, and the split comes after #14259 lands (the snap census owner). The entry's comment says so.
Gate:
scripts/check_file_size.shexits 0 on this branch ("every exemption asserts its current size"). Onlyscripts/check_file_size.shchanges (+2 lines).