Repository navigation
Preserve bound native TCP sockets through asynchronous connection - #120
Closed
proggeramlug wants to merge 2 commits into
Closed
proggeramlug wants to merge 2 commits into
proggeramlug wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
proggeramlug
force-pushed
the
codex/wasi-bound-tcp
branch
from
October 23, 2026 18:50
a3f7a00 to
9275e39
Compare
proggeramlug
added a commit
that referenced
this pull request
Nov 8, 2026
…d shared stdio Upstreams the provider repairs Perry has been carrying as a patched copy of alpha.10, so its WASI provider, native async and concurrent HTTP paths can run on a published turnloop. - ExecutorHandle::connect_bound and Backend::open_bound_tcp: connect an explicitly bound, not-yet-connected native TCP socket through the driver (Unix and IOCP), keeping its local address. - AsyncIo::shutdown_receive: shut down the receive side of a stream without disturbing writes in flight; refused while a read is pending. - AsyncDatagram and ExecutorHandle::datagram: an executor adapter that keeps UDP packet boundaries and source addresses. - backend::stdio: overlapping handles on one Unix stdio descriptor share its ownership, so closing one does not reset the settings another relies on. - Keepalive parameter setters on Unix, IOCP and WASI use the shared validation helpers without changing whether keepalive is enabled. The IOCP unit tests move to backend/iocp/tests.rs; no test is dropped. Supersedes #119, #120, #121, #122 and #123.
proggeramlug
added a commit
that referenced
this pull request
Nov 8, 2026
…d shared stdio Upstreams the provider repairs Perry has been carrying as a patched copy of alpha.10, so its WASI provider, native async and concurrent HTTP paths can run on a published turnloop. - ExecutorHandle::connect_bound and Backend::open_bound_tcp: connect an explicitly bound, not-yet-connected native TCP socket through the driver (Unix and IOCP), keeping its local address. - AsyncIo::shutdown_receive: shut down the receive side of a stream without disturbing writes in flight; refused while a read is pending. - AsyncDatagram and ExecutorHandle::datagram: an executor adapter that keeps UDP packet boundaries and source addresses. - backend::stdio: overlapping handles on one Unix stdio descriptor share its ownership, so closing one does not reset the settings another relies on. - Keepalive parameter setters on Unix, IOCP and WASI use the shared validation helpers without changing whether keepalive is enabled. The IOCP unit tests move to backend/iocp/tests.rs; no test is dropped. Supersedes #119, #120, #121, #122 and #123.
Contributor
Author
|
Superseded by #131, which upstreams all of Perry's provider repairs (merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WASI TCP hosts must reserve a local endpoint and set handshake-sensitive options before choosing a peer. The existing connect API creates a fresh socket, so it cannot preserve that state.
Add
Driver::tcp_connect_boundandExecutorHandle::connect_boundfor exclusively owned, bound but unconnected native transports. Unix and Windows retain the socket identity, local endpoint and existing options while using the existing asynchronous connect, timeout and cancellation machinery. Setup failure releases native ownership and core reservations; dropping an unpolled or pending future releases its transport. Backends without native transport adoption returnUnsupported.Validation:
a3f7a0074c080ae47bef8bdfb92c42472902f328, all 18 native CI arms pass (Linux x86_64/arm64, macOS and Windows), including the six new bound-TCP contracts on Windows. Native Clippy passes on all four platforms; WASI 0.2/0.3, browser, loom, Miri and workflow/dependency checks pass. The full required matrix, including protocol, instruction review andci-gate, passes in CI 39857872029.Stacked on #119 while that dependency repair awaits integration. No release/version or dependency-policy change. Draft until platform qualification and the dependent Perry WASI integration are complete.