Repository navigation
Add receive shutdown that preserves stream writes - #122
Closed
proggeramlug wants to merge 2 commits into
Closed
proggeramlug wants to merge 2 commits into
proggeramlug wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
proggeramlug
force-pushed
the
codex/wasi-tcp-controls
branch
from
October 23, 2026 18:50
9c64952 to
c8ef920
Compare
proggeramlug
force-pushed
the
codex/wasi-receive-shutdown
branch
from
October 23, 2026 18:50
605ee21 to
8a584f7
Compare
proggeramlug
added a commit
that referenced
this pull request
Nov 8, 2026
…d shared stdio Upstreams the provider repairs Perry has been carrying as a patched copy of alpha.10, so its WASI provider, native async and concurrent HTTP paths can run on a published turnloop. - ExecutorHandle::connect_bound and Backend::open_bound_tcp: connect an explicitly bound, not-yet-connected native TCP socket through the driver (Unix and IOCP), keeping its local address. - AsyncIo::shutdown_receive: shut down the receive side of a stream without disturbing writes in flight; refused while a read is pending. - AsyncDatagram and ExecutorHandle::datagram: an executor adapter that keeps UDP packet boundaries and source addresses. - backend::stdio: overlapping handles on one Unix stdio descriptor share its ownership, so closing one does not reset the settings another relies on. - Keepalive parameter setters on Unix, IOCP and WASI use the shared validation helpers without changing whether keepalive is enabled. The IOCP unit tests move to backend/iocp/tests.rs; no test is dropped. Supersedes #119, #120, #121, #122 and #123.
proggeramlug
added a commit
that referenced
this pull request
Nov 8, 2026
…d shared stdio Upstreams the provider repairs Perry has been carrying as a patched copy of alpha.10, so its WASI provider, native async and concurrent HTTP paths can run on a published turnloop. - ExecutorHandle::connect_bound and Backend::open_bound_tcp: connect an explicitly bound, not-yet-connected native TCP socket through the driver (Unix and IOCP), keeping its local address. - AsyncIo::shutdown_receive: shut down the receive side of a stream without disturbing writes in flight; refused while a read is pending. - AsyncDatagram and ExecutorHandle::datagram: an executor adapter that keeps UDP packet boundaries and source addresses. - backend::stdio: overlapping handles on one Unix stdio descriptor share its ownership, so closing one does not reset the settings another relies on. - Keepalive parameter setters on Unix, IOCP and WASI use the shared validation helpers without changing whether keepalive is enabled. The IOCP unit tests move to backend/iocp/tests.rs; no test is dropped. Supersedes #119, #120, #121, #122 and #123.
Contributor
Author
|
Superseded by #131, which upstreams all of Perry's provider repairs (merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WASI receive shutdown must stop and discard input while the socket remains writable. Cancelling the caller's read future alone leaves its native read slot owned by
AsyncIo.Add
Driver::shutdown_receiveandAsyncIo::shutdown_receive. Unix and Windows perform receive-only native shutdown; WASI 0.2 forwards the corresponding socket operation. After native success the adapter cancels and discards its read slot, retains its buffer until terminal acknowledgement, and returns EOF on subsequent reads. Repeated calls succeed and sends remain independent. Unsupported transports fail without changing adapter state. WASI 0.3/web explicitly return Unsupported for this synchronous control; their receive streams need asynchronous cancellation before endpoint disposal.Validation: Linux passes 194 core/contract tests plus three doctests, and all three new executor contracts in release. macOS passes the three executor contracts and the independent native probe. Both pass all-target core/contract Clippy with warnings and undocumented unsafe blocks denied. WASI 0.2 passes all 53 contracts in debug and release under checksum-pinned Wasmtime 46.0.0, plus all-target Clippy. Tests cover a pending read beside live writes, discarding a partially consumed completion, UDP rejection preserving a read, and repeated shutdown. An independent probe detaches the native socket and verifies shutdown through the OS, then sends exact bytes through its surviving write direction. The full required CI matrix is green on 605ee21: native Linux x86-64/ARM64, macOS and Windows; WASI 0.2/0.3 builds and protocols; web, Miri, Loom, dependencies, and protocol gates. CI run.
Stacked on #121. No dependency, feature, release or policy changes. Remains draft pending dependent Perry WASI integration.