Repository navigation
Preserve HTTP/1 field spelling without weakening validation - #124
Closed
proggeramlug wants to merge 1 commit into
Closed
proggeramlug wants to merge 1 commit into
proggeramlug wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
proggeramlug
force-pushed
the
codex/wasi-http-field-case-20261023
branch
from
October 23, 2026 18:50
d62add8 to
9589d1d
Compare
proggeramlug
force-pushed
the
codex/wasi-datagram-adapter
branch
from
October 23, 2026 18:50
b63a4ee to
8d1c608
Compare
proggeramlug
added a commit
that referenced
this pull request
Nov 8, 2026
…amed SETTINGS and PING - Header::new_preserving_case: HTTP/1 keeps the field and trailer name spelling the caller gave, without weakening validation. - HTTP/2 SETTINGS carry only the options the caller named, and any HEADER_TABLE_SIZE the peer advertises is honoured (hpack set_allowed). - PUSH_PROMISE is handled in the core; promised stream ids are validated. - SETTINGS and PING acknowledgements report what they measured; ping() validates its arguments, and an unsolicited PING acknowledgement is an INTERNAL_ERROR. Supersedes #124.
proggeramlug
added a commit
that referenced
this pull request
Nov 8, 2026
…amed SETTINGS and PING - Header::new_preserving_case: HTTP/1 keeps the field and trailer name spelling the caller gave, without weakening validation. - HTTP/2 SETTINGS carry only the options the caller named, and any HEADER_TABLE_SIZE the peer advertises is honoured (hpack set_allowed). - PUSH_PROMISE is handled in the core; promised stream ids are validated. - SETTINGS and PING acknowledgements report what they measured; ping() validates its arguments, and an unsolicited PING acknowledgement is an INTERNAL_ERROR. Supersedes #124.
Contributor
Author
|
Superseded by #131, which upstreams all of Perry's provider repairs (merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP/1 decoding currently lowercases every field name, so a WASI 0.3 HTTP host cannot preserve original field spelling through
fields.copy-allor forwarding. Preserve parsed names and addHeader::new_preserving_casefor HTTP/1 serialization. The existing constructor keeps its lowercase behavior for compatibility with HTTP/2 callers.Keep Host counting and forbidden-trailer validation case-insensitive. Regression coverage checks exact header/trailer round trips, interleaved repeated fields, mixed-case duplicate Host rejection, and mixed-case forbidden trailers on both decoding and encoding.
Validation on Linux: 93 local HTTP tests passed (three external tests initially ignored); the separate required-fixture run passed all 21 asynchronous and nine interoperability tests with zero ignored. All-target/all-feature HTTP Clippy, path validation and feature-mode checks passed. Perry's downstream P3 provider passed 276 development and 276 production panic-abort tests with the codec fix. The full repository/platform matrix is left to CI.
Stacked on #123 to retain the shared provider-validation dependency snapshot. Kept draft until the broader Perry WASI integration is qualified.