Repository navigation
[8.4.x] Add getters to Atom\Link, Media\Content, and Media\Thumbnail - #8
Merged
MoamenEltouny merged 1 commit intoOct 8, 2026
Conversation
These extensions only exposed setters, so their values could not be read back once built. Add getters mirroring every setter, following the convention of the other value objects. Content::isDefault() is already the setter, so its getter is getIsDefault(). The generated XML is unchanged. Refs Pharaonic#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds getters to
Atom\Link,Media\Content, andMedia\Thumbnail, which previously only had setters. Each getter mirrors an existing setter and follows the convention of the other value objects (Image,Encoded,Creator, ...).Content::isDefault()is already the setter, so its getter is namedgetIsDefault().The generated XML is unchanged. The new tests assert on the getters directly, since this change adds no output; the existing XPath tests keep covering serialization and still pass.
As requested in the issue, there is one PR per version branch (8.0.x to 8.5.x). They contain the same commit; only the
CHANGELOG.mdplacement differs per branch.Refs #3
Type of change
Checklist
8.4.x).composer checkpasses./docsis updated if the public API or usage changed.CHANGELOG.mdis updated underUnreleased.