Repository navigation
Backport the Unicode 15 to 17 fixes to 8.2.x - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the Unicode 15 to 17 fixes from #11 to the
8.2.xline, for release as8.2.1.The tests compare the package against the Unicode data of the PHP build they run on. Windows PHP 8.4 ships newer Unicode data than Ubuntu, which exposed two gaps that apply to this line as well:
src/Resources/numbers.php(Kawi, Nag Mundari, Garay, Sunuwar, Gurung Khema, Kirat Rai, Ol Onal, Tolong Siki, Myanmar Pa-O and Eastern Pwo Karen, and outlined digits), so they were not converted to ASCII digits. The table now matches Unicode 17 exactly: every decimal digit maps, and every entry is a real zero.UnicodeNormalizer::MAY_CHANGE_UNDER_NFCmissed 9 Tulu-Tigalari, Gurung Khema and Kirat Rai characters from Unicode 16. When PCRE uses older Unicode data than ext-intl, text in those scripts skipped normalization. Both lists were derived from the official Unicode 17 data files.The CHANGELOG has a
8.2.1entry.