Repository navigation
Backport portable-ascii 1.x support to 8.1.x - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the portable-ascii 1.x support from #17 to the
8.1.xline, for release as8.1.2.Laravel 8 requires
voku/portable-ascii^1.6.1 and runs on PHP 8.0 and 8.1.8.0.xalready allows it (8.0.4). Without this change, a Laravel 8 app on PHP 8.1 would resolve this line and hit the same install conflict. Laravel 9 and later use portable-ascii 2.x, so the 8.2.x to 8.5.x lines don't need it.voku/portable-ascii:^1.6.1 || ^2.0src/Resources/portable-ascii-1.php), so slugs are identical with either version.Checked on PHP 8.1: the test suite passes on portable-ascii 1.6.1 and 2.1.1, and a letter-by-letter comparison across all 59 portable-ascii languages shows 0 differences.
The CHANGELOG has an
8.1.2entry, and the installation docs list both versions.