fix(ci): include .nojekyll when publishing the javadoc branch - #14
Merged
Conversation
upload-artifact@v4 omits hidden files by default, so generate's .nojekyll never reached publish. Include hidden files on upload and touch .nojekyll on the javadoc branch instead of copying it. Co-authored-by: Nonnipat Tangrojjanakhajorn <contact@pinont.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
publish-javadoconmainfailed after #10 (c7b8441): generate stagedjavadoc-site/.nojekyll, then publish died withcp: cannot stat '.../javadoc-site/.nojekyll'.actions/upload-artifact@v4(v4.4+) defaultsinclude-hidden-filestofalse, so the dotfile never entered the artifact.What
Small fix in
.github/workflows/publish-javadoc.ymlonly:include-hidden-files: trueon the HTML artifact upload.touch .nojekyllon thejavadocbranch instead of copying it from the artifact, so publish still works if a future upload omits hidden files.Does not invent
MAVEN_REPO_TOKENor git-pushsingularity-maven.Verify
publish-javadocgenerate should pass; publish skips on pull_request (expected).main, publish should push HTML to thejavadocbranch without the missing.nojekyllerror.