Fail closed when TES edit_control lookup is Err - #32
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Fail closed when TES edit_control lookup is Err#32Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
A Failed get_edit_control was assembled as None, so is_stale_tweet treated superseded (pre-edit) tombstones as current. Drop those ids before assemble. Genuine NotFound (never edited) is unchanged. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five-line proof
TesHydrator::hydrate_tweetsget_edit_control(timed_resultsFound / NotFound / Failed)FilterTweetsVerdict::unresolved_authorDropedit_control = None;is_stale_tweettreats None as currentedit_controlwas the leftover.Genuine
NotFound/Ok(None)(never edited) is unchanged.retain_candidates_with_usable_edit_controldrops Failed ids before assemble.Tests: Found / NotFound / empty batch stay; Failed RPC and timeout drop; retain keeps only usable ids; assemble still collapses Failed to None.
Standalone decision-table harness (same match arms): 12/12 passed.
cargo testcannot run. Public dump has no visibility-filtering crate manifest.Fork PR: none