Stop For You VF from skipping Phoenix reply parents - #62
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Stop For You VF from skipping Phoenix reply parents#62Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
Phoenix retrieval, MOE, Topics, and TweetMixer set in_reply_to_tweet_id but leave ancestors empty. Ancillary VF only fetched candidate.ancestors, so a mute or block on the parent never dropped the reply. Thunder already copies the parent into ancestors. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
Owner
Author
|
wrong tree: upstream already at xai-org#180. Close fork twin; do not squash-merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Phoenix retrieval, MOE, Topics, and TweetMixer set
in_reply_to_tweet_idand leaveancestorsempty. Thunder and Latest Following copy the parent intoancestors.VFCandidateHydratoronly fetchescandidate.ancestorsas ancillary ids.should_drop_ancillaryonly walks that list. A mute or block on the parent tweet never reachesAncillaryVFFilter, so the reply still ranks on For You.This is not conversation-gap expansion (xai-org#97). Not mixer
ancestor_usersmute/block (xai-org#101 / xai-org#111). Not quote/RT handle mute-keyword (xai-org#140 / xai-org#164). Not civic followee quotes (xai-org#178).Fix
When
ancestorsis empty, treatin_reply_to_tweet_idas the reply parent for VF fetch and ancillary drop. Thunder's existing ancestor list is unchanged.Proof
in_reply_to_tweet_idand leaveancestorsemptyancestorsonly; OON Phoenix replies never populated that listin_reply_tointoancestorsTests