Skip to content

0.1.2 (14/15): file-panel ownership and Finder read fixes - #15

Merged
trevoedwards merged 3 commits into
mainfrom
pr/0.1.2-14-file-panels
Nov 1, 2026
Merged

trevoedwards merged 3 commits into
mainfrom
pr/0.1.2-14-file-panels

Conversation

@trevoedwards

Copy link
Copy Markdown
Collaborator

Part 14 of the 0.1.2 stack. Depends on part 13; base: pr/0.1.2-13-benchmarks. Merge the preceding PR first. Existing topic commits and AI co-author trailers are preserved; already-merged CI fixes are carried through the stack.

Ref-based scrolling in attached Open/Save panels was blocked by their separate service process, and persistent Finder leaf-read errors could make otherwise readable file selections unusable. This adds precise ownership and read rules.

  • Attribute a remote panel hit to a host only when that specific service PID is freshly present in the host's attached panel, agrees with the hit PID and belongs to the panel by AX ancestry. Linked popup menus can overflow the frame. Drag destinations resolve their own host and app policy.
  • Limit the Finder AXChildren exception to selection reads on known leaves with readable file identity. Readable item URLs can identify their file without descending children. Failed name/URL reads and unreadable rows, containers or sidebars still fail closed.
  • Remove the broader walker exception so ordinary snapshots retain incomplete-read reporting. Error text asks the person to check Finder; only the human-facing docs describe quitting/reopening a persistently stuck Finder.

Tests cover cross-host panel services, ancestry, drag destinations, readable leaf failures, unreadable sidebar/list items and reference identity. The combined GUI run passed the file-panel and Finder route suites. The original review fixes remain included in this PR.

PR prepared with Codex. Original implementation co-author trailers are retained.

@trevoedwards
trevoedwards added this pull request to stack #17 November 1, 2026 03:53
@trevoedwards
trevoedwards force-pushed the pr/0.1.2-14-file-panels branch 4 times, most recently from 28a39f5 to f6fee8f Compare November 1, 2026 03:55
Base automatically changed from pr/0.1.2-13-benchmarks to main November 1, 2026 03:55
trevoedwards and others added 3 commits October 31, 2026 20:55
Recognize service-owned panel pixels and AX-linked popup menus only with a freshly verified panel attached to the host. Share the check across scroll, click, drag and hover targeting while retaining route and clipping guards.

Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Treat repeated AXChildren failure on known leaves as empty only when the needed name and URL reads remain trustworthy. Keep rows, containers and failed file identities closed, apply the narrow exception to snapshots, and provide a person-only recovery hint.

Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Bind panel-service input to the specific processes attached to the target host, matching the hit pid and panel ancestry. Resolve drag destination hosts independently and enforce their policy.

Keep the leaf children exception in selection reads only, fail closed on unreadable Finder sidebar and list items, and move Finder recovery instructions to the human-facing security documentation.

Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
(cherry picked from commit f69d00f657d525e862f5ec0166f47ddc2cf17904)
@trevoedwards
trevoedwards force-pushed the pr/0.1.2-14-file-panels branch from f6fee8f to 0bf95df Compare November 1, 2026 03:55
@trevoedwards
trevoedwards merged commit 93d64f6 into main Nov 1, 2026
1 check passed
@trevoedwards
trevoedwards deleted the pr/0.1.2-14-file-panels branch November 1, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant