Repository navigation
0.1.2 (14/15): file-panel ownership and Finder read fixes - #15
Merged
Merged
Conversation
trevoedwards
force-pushed
the
pr/0.1.2-14-file-panels
branch
4 times, most recently
from
November 1, 2026 03:55
28a39f5 to
f6fee8f
Compare
Recognize service-owned panel pixels and AX-linked popup menus only with a freshly verified panel attached to the host. Share the check across scroll, click, drag and hover targeting while retaining route and clipping guards. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Treat repeated AXChildren failure on known leaves as empty only when the needed name and URL reads remain trustworthy. Keep rows, containers and failed file identities closed, apply the narrow exception to snapshots, and provide a person-only recovery hint. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Bind panel-service input to the specific processes attached to the target host, matching the hit pid and panel ancestry. Resolve drag destination hosts independently and enforce their policy. Keep the leaf children exception in selection reads only, fail closed on unreadable Finder sidebar and list items, and move Finder recovery instructions to the human-facing security documentation. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com> (cherry picked from commit f69d00f657d525e862f5ec0166f47ddc2cf17904)
trevoedwards
force-pushed
the
pr/0.1.2-14-file-panels
branch
from
November 1, 2026 03:55
f6fee8f to
0bf95df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 14 of the 0.1.2 stack. Depends on part 13; base:
pr/0.1.2-13-benchmarks. Merge the preceding PR first. Existing topic commits and AI co-author trailers are preserved; already-merged CI fixes are carried through the stack.Ref-based scrolling in attached Open/Save panels was blocked by their separate service process, and persistent Finder leaf-read errors could make otherwise readable file selections unusable. This adds precise ownership and read rules.
Tests cover cross-host panel services, ancestry, drag destinations, readable leaf failures, unreadable sidebar/list items and reference identity. The combined GUI run passed the file-panel and Finder route suites. The original review fixes remain included in this PR.
PR prepared with Codex. Original implementation co-author trailers are retained.