Fix Minecraft 1.21.1 build and animated mesh rendering - #40
Open
kltyton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.21.1 branch fails against its mapped Minecraft and NeoForge APIs and bypasses deformed geometry when native X bend is zero. This completes the existing port for Fabric and NeoForge and keeps the deformed-mesh render path active during PAL animation.
CubeDefinition.dimensionsto its 1.21.1Vector3fdescriptor and use the static FML loading-list API.Validation: Gradle
build -Pmod_version=2.0.0+alpha.1passes for both loaders. Fabric and NeoForge development clients were tested in the overworld. An additional Fabric downstream animation test exercised X/Y/Z bend and bend-only position/scale; its manual validation passed after checking that the running remapped dependency contained the fix. No server-side behavior or unrelated renderer integrations are changed.