Repository navigation
Allow corrected table creation after a Perspective failure - #208
Closed
pengpengyi92 wants to merge 1 commit into
Closed
pengpengyi92 wants to merge 1 commit into
pengpengyi92 wants to merge 1 commit into
Conversation
Signed-off-by: Pengyi Peng <pengpengyi92@users.noreply.github.com>
pengpengyi92
requested review from
gauglertodd,
ptomecek and
timkpaine
as code owners
November 13, 2026 19:18
gauglertodd
approved these changes
Nov 13, 2026
gauglertodd
left a comment
Collaborator
There was a problem hiding this comment.
cool, looks good to me - approving.
3 of 11 tasks
4 of 6 tasks
Member
|
Thanks for the PR! I've moved to #210 to consolidate and trim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Register a table in
TableHostonly after Perspective successfully creates it.Currently
new_table()writes_schemasand_temporal_columnsbeforecalling the Perspective client. If that call raises (for example an invalid
column type),
names()still advertises the failed table. A corrected retryreturns
Falsebecause the name is cached, andupdate()then raisesKeyErrorbecause there is no backend table. A mixed schema batch can alsopublish a dashboard tab for the table that failed to exist.
Create the real table first, then register its metadata and handle together.
The original Perspective error still propagates; no failed operation is
silently accepted. Existing-table idempotency, limits and the established
partial-batch behavior remain unchanged. No version/dependency/API changes.
Three regression tests use the actual native Perspective client, not a
mock: failed creation leaves no metadata, corrected retry accepts data, and
a failed table does not become a phantom tab alongside an earlier valid table.
Type of Change
Validation
Base:
d7a553243c2a3a654e3119140df773d1f4695791. Windows 11 / Python 3.12.14,Perspective 5.6.1, Ray 2.60.0, spaday 0.14.1, transports 0.12.3.
python -m pytest raydar/tests/test_table_creation.py -q -o addopts= python -m pytest raydar/tests/test_table_creation.py \ raydar/tests/test_dashboard.py raydar/tests/test_ops.py \ raydar/tests/test_schema.py \ -k 'not TestDashboardApp and not TestLocalDashboard' -q -o addopts= python -m ruff check raydar python -m ruff format --check raydarThe imported checkout was verified in each clean-base/candidate control.
the three regressions: 40 passed, 7 existing server/app cases deselected.
TestDashboardApp: base 38 passed,2 failed; candidate 41 passed, 2 failed, the same failure IDs:
test_poll_loop_survives_a_bad_batchandtest_stop_is_idempotent_and_releases_the_port. In this Windows environmentthe local server thread does not stop and port reuse raises WinError 10048.
These were observed before production edits and are not fixed in this PR.
150-second timeout on the base; no completed test count or pass is claimed
for that run. Full Ray actor/Serve integration and
make testare notvalidated locally. Upstream CI is separate evidence.
Checklist
make lint(Python Ruff checks above pass; documentation tools not run)make test(scoped passes and inherited Windows limits above)Prepared with OpenAI Codex assistance. Tests and clean-base controls were
actually executed. The author explicitly authorized DCO sign-off for this
original contribution only. This is a new table-creation recovery fix, not a
claim that the old Ray Serve issue #57 was reproduced or resolved.