Fix translations - #1648
Conversation
Naramsim
left a comment
There was a problem hiding this comment.
I left some comments. If you say you've already verified most of the strings then we can merge the contribution in, after the sorting. Thanks for bringing the data here as well!
|
@Naramsim Done. Yeah, this was scripted to import directly from poke-corpus which is datamined from the games themselves. I sorted the translations I added. Do you want me to also sort the translations I didn't add? There's some other translations out of order (similar reasons to me, probably - someone wrote a script that added missing translations to the end rather than in order). It's actually really easy for me to fix for you, if you want me to. |
|
Yes, if you could sort them all that would be really appreciated. Can you do it in a separate PR though? |
|
@Zarel thanks a lot for the contribution! |
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
Change description
Hi! Pokémon Showdown is in the process of adding support for other languages. We were originally going to use PokéAPI to source species/move/ability/item names, but PokéAPI seems to be missing a few, so we're sourcing them from https://github.com/abcboy101/poke-corpus instead.
I figured I'd contribute the translations we sourced from poke-corpus back to PokéAPI, so everyone can be up-to-date.
In addition to the missing ones, you also seem to be using a mixture of Simplified and Traditional Chinese in your Traditional Chinese translation, which I also corrected for you.
AI coding assistance disclosure
Nope, no code at all.
Contributor check list