Repository navigation
add FreePlay bar animation - #476
Closed
BitsAndDopamine wants to merge 1 commit into
Closed
BitsAndDopamine wants to merge 1 commit into
BitsAndDopamine wants to merge 1 commit into
Conversation
Author
|
I am not completely satisfied with the display of short notes played right after another. Right now they merge into one big bar. EDIT: seems to be only an issue when you play with your mouse. |
Owner
|
We already have a waterfall renderer that can be used for this without duplicating the logic, can you give #478 a try? While at it it also solves the buggy double overlapping waterfalls in the recording mode. |
Author
|
Oh, sorry I haven't seen that. I'll test this PR instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bars flying up similar to free play in synthesia:
The code was written by Mistral Large 4 in OpenCode, but I reviewed and tested everything.