Skip to content

feat: SDL support for keybind and window handling - #1018

Open
saadndm wants to merge 3 commits into
Polyfrost:v1from
saadndm:feat/sdl
Open

feat: SDL support for keybind and window handling#1018
saadndm wants to merge 3 commits into
Polyfrost:v1from
saadndm:feat/sdl

Conversation

@saadndm

@saadndm saadndm commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

We should prob give this to testers for testing before next release

feat: SDL support for keybind and window handling

  • Fixes all keybind/window handling for 26.3, uses shared InputConstants wherever possible
  • Tested on 1.8.9 ornithe with lenis

feat(keybind): migrate keybinds to InputConstant names

  • Saves keybinds using InputConstants key names instead of GLFW specific ints
  • Migrates existing GLFW keyboard and mouse bindings on first load using a GLFW -> SDL table
  • Unsupported keys are unbound with a warning:
image
  • Switching back to old OneConfig versions after migrating will reset the config
  • Tests: MinecraftKeybindCodecTest and OneConfigKeybindAdapterTest

Checklist

  • I made a clear description of what was changed
  • I stated why these changes were necessary
  • I updated documentation or said what needs to be updated
  • I made sure these changes are backwards compatible
  • This pull request is for one feature/bug fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant