fix: support hexadecimal OpenFeature numeric variants - #980
Merged
Merged
Conversation
Contributor
posthog-python Compliance ReportDate: 2026-09-25T06:50:20.753606+00:00 ✅ All Tests Passed!121/121 tests passed Capture_V1 Tests✅ 95/95 tests passed View Details
Capture_Ai Tests✅ 5/5 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
Feature_Flags_Local_Evaluation Tests✅ 4/4 tests passed View Details
|
5 tasks
Contributor
|
[Medium risk] Adds hexadecimal number parsing to the feature flag provider. The PR should not merge until numeric remote variants retain their previous resolver behavior. Reviews (1) · Last reviewed commit: "fix: support hexadecimal OpenFeature num..." |
patricio-posthog
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The Python OpenFeature provider rejects hexadecimal variants such as
0x10, while the Node provider accepts them. This difference came up while comparing providers in PostHog/posthog-elixir#214 (comment).Both Python numeric resolvers now accept unsigned hexadecimal integers with
0xor0Xprefixes. The integer resolver returns an integer and the float resolver returns a float. Decimal parsing, numeric non-string variants, and the original variant metadata are unchanged. Hex values are converted directly to integers without a decimal-string round trip, so large integers are not subject to Python’s decimal conversion digit limit. Values too large for a float returnTypeMismatchError. Signed, malformed, fractional, and underscore-separated hexadecimal strings remain type mismatches.💚 How did you test it?
uv run --package openfeature-provider-posthog pytest -q: 68 passed.📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with Pi using local file editing, shell tests, and the isolated autoreview helper. The scope is hexadecimal numeric variants only, not full JavaScript number-parser parity. No shared session link is available.