Release 0.1.3: pass our own rules - #35
Merged
Merged
Conversation
The v0.1.2 release failed its smoke test. Not the install -- that worked
on both platforms -- but the scan that follows it, which runs
straitjacket over this repository with findings fatal, and found three:
site/wrangler.toml:11:1 [no-comments]
site/wrangler.toml:21:1 [no-comments]
site/wrangler.toml:22:1 [no-comments]
A header one line past the ten it is allowed, and two more beside the
setting they described. The reasoning is worth keeping, so it is folded
into the header rather than deleted, and `run_worker_first` is explained
where the header explains everything else about this file.
The `action` job added yesterday ran the same scan and passed, because I
had it ignore findings -- the manifest was what I wanted proved. So the
first thing to notice was the release, after the tag was pushed and the
release published. It fails on findings now. A check that catches this
has to run where it can still be fixed.
v0.1.2 stays as it is. Its archives are built, published, and install
correctly; only the crates.io step was skipped, which 0.1.3 does. Moving
a tag people can already install from is worse than spending a version.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01361quprG7tUgaVFKAmKtJZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.1.2 release failed its smoke test. Not the install — that worked on both platforms, downloading and running
v0.1.2— but the scan that follows it, which runs straitjacket over this repository with findings fatal:A header one line past the ten it is allowed, and two more sitting beside the setting they described. All three say something worth keeping, so they are folded into the header rather than deleted —
run_worker_firstnow gets explained where the header explains everything else about the file. Scan is clean: no findings in 91 files.The check that should have caught it
The
actionjob I added yesterday runs this exact scan, and it passed — because I setfail-on-findings: false, since what I wanted proved was that the manifest loads. So the first thing to notice was the release smoke test, after the tag was pushed and after the release was published.It fails on findings now. A check that catches this has to run where it can still be fixed.
Why 0.1.3 and not a re-cut v0.1.2
v0.1.2 is published, has all five assets, and installs correctly — the smoke test proved that much before it got to the scan. The only step it skipped is crates.io, which is why the registry still says 0.1.1. Moving a tag people can already install from is worse than spending a version number, so v0.1.2 stays exactly as it is and 0.1.3 carries the fix.
cratebank#25 pins to v0.1.2 and is unaffected either way — the manifest fix it needs is in both.
Local:
fmt,clippy -D warnings, 53 tests, rule manifest current, self-scan clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01361quprG7tUgaVFKAmKtJZ