Merge links into nodes: Merge nodes on links if there are no node injection sensors - #1584
Merged
figueroa1395 merged 6 commits intoSep 10, 2026
Merged
Conversation
Member
Author
|
Benchmark run vs |
figueroa1395
previously approved these changes
Sep 9, 2026
mgovers
force-pushed
the
pgm/feature/prepare-link-registration
branch
from
September 9, 2026 12:40
10342c9 to
90f60cc
Compare
This reverts commit 90f60cc. Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
force-pushed
the
pgm/feature/actually-register-links-for-merge
branch
from
September 9, 2026 12:47
ee827d6 to
8a8e92a
Compare
nitbharambe
previously approved these changes
Sep 9, 2026
Base automatically changed from
pgm/feature/prepare-link-registration
to
feature/link-registration-dual-code-path
September 9, 2026 12:50
…/fix/multiple-faults-post-merge-links Signed-off-by: Martijn Govers <martijn.govers@alliander.com>
…post-merge-links Multiple infinite faults on a bus incorrect fault output: 2nd test post merge links with nodes
mgovers
commented
Sep 9, 2026
mgovers
commented
Sep 9, 2026
…ure/actually-register-links-for-merge
Base automatically changed from
feature/link-registration-dual-code-path
to
main
September 9, 2026 17:16
mgovers
dismissed stale reviews from nitbharambe and figueroa1395
September 9, 2026 17:16
The base branch was changed.
|
figueroa1395
approved these changes
Sep 10, 2026
nitbharambe
approved these changes
Sep 10, 2026
figueroa1395
deleted the
pgm/feature/actually-register-links-for-merge
branch
September 10, 2026 08:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This is the actual enablement of merging nodes on links (a.k.a. merging links into nodes).
As described in #1550, a dual code path is chosen:
v1.13.166): Links are modeled to have a finite admittance.v1. Node injection sensors are deprecated in [DEPRECATION] Deprecating node injection power sensor #1334 and will be removed inv2.Documentation is in #1553 .
This reverts commit e743f9c.
Fixes #35