Skip to content

Pin MessagePack to 3.1.12 and keep build package versions only in Directory.Build.props - #12

Merged
Prengemann merged 1 commit into
mainfrom
pakete/messagepack-pin-build-props
Nov 13, 2026
Merged

Prengemann merged 1 commit into
mainfrom
pakete/messagepack-pin-build-props

Conversation

@Prengemann

Copy link
Copy Markdown
Contributor

Why

Two leftovers from the package update (internal board, issues 6 and 7):

  • MessagePack floated with 3.*, so every restore could pick a different version, even with DotNet.ReproducibleBuilds in place.
  • Directory.Build.props still named Nerdbank.GitVersioning 3.9.50, DotNet.ReproducibleBuilds 2.0.2 and Microsoft.SourceLink.GitHub 8.0.0. Both csproj files overrode these with <PackageReference Update=…>, so every update had to be made in three places.

Changes

  • EvenBetterFastSim.csproj: MessagePack goes from 3.* to 3.1.12, the version restore already resolved. It is the newest stable 3.x on nuget.org (4.0.0 is only at rc.1), and it has no deprecation and no known vulnerability.
  • Directory.Build.props: Nerdbank.GitVersioning 3.10.94, DotNet.ReproducibleBuilds 2.0.5, Microsoft.SourceLink.GitHub 10.0.404. These are the versions the Update items forced until now.
  • Both csproj files: the ItemGroup with the three <PackageReference Update=…> lines is gone. The versions now live only in Directory.Build.props.
  • release.yml: the comment behind nbgv --version 3.10.94 now points to Directory.Build.props. The version itself still matches.

Verification

  • Linux SDK 10.0.404, Release build of the app and of the test project: 0 warnings, 0 errors. Tests under Wine with Windows .NET: 7/7 pass.
  • obj/project.assets.json before and after, with a forced restore of both projects:
    • App: the only difference is the declared range of MessagePack ([3.*, ) → [3.1.12, )). The resolved package stays 3.1.12, and every other package is unchanged.
    • Tests: the file is byte-identical.
    • Restore logged nothing.
  • msbuild -getItem:PackageReference shows the same effective versions in both projects as before: 3.10.94 / 2.0.5 / 10.0.404, each with PrivateAssets=All.
  • The app's bin/Release/net10.0-windows7.0 holds the same files with the same SHA-256 hashes as before. EvenBetterFastSim.dll/.exe were left out of the comparison because they carry the commit-based version.
  • The only projects under Directory.Build.props are these two, so no other project picks up a different version.
  • actionlint 1.7.12 on release.yml and ci.yml: no findings.
  • Not run on Windows yet: the CI run of this PR (windows-latest) is the first check there.

Merge

Please use a squash merge. A merge to main changes project files and therefore triggers release.yml, which publishes the next pre-release (v1.0.0-build.6 if the pattern holds). The bundled runtime stays the same as in v1.0.0-build.5.

Internal board (secsgem/evencoolerfastsim): implements issues 6 and 7.

🤖 Generated with Claude Code

…ectory.Build.props

- MessagePack: `3.*` -> `3.1.12`, the version restore already resolved. It is
  the newest stable 3.x on nuget.org (4.0.0 is only at rc.1).
- Directory.Build.props: Nerdbank.GitVersioning 3.10.94,
  DotNet.ReproducibleBuilds 2.0.5, Microsoft.SourceLink.GitHub 10.0.404.
  These are the versions both csproj files forced through
  `<PackageReference Update=...>`; those overrides are removed.
- release.yml: the nbgv comment now points to Directory.Build.props.

Resolved packages in obj/project.assets.json are unchanged for both
projects.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Prengemann
Prengemann merged commit ff3f43d into main Nov 13, 2026
1 check passed
@Prengemann
Prengemann deleted the pakete/messagepack-pin-build-props branch November 13, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant