Skip to content

fix: apply theme tokens to page surfaces - #969

Merged
greatest0fallt1me merged 1 commit into
Predictify-org:mainfrom
Killerjunior:codex/962-theme-body-tokens
Sep 29, 2026
Merged

greatest0fallt1me merged 1 commit into
Predictify-org:mainfrom
Killerjunior:codex/962-theme-body-tokens

Conversation

@Killerjunior

Copy link
Copy Markdown
Contributor

Description

Make page backgrounds and foreground text respond to the selected theme. Dark mode retains its existing navy and pale text colors; light and high-contrast modes now control the shared page surfaces through theme tokens.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Style/UI changes
  • Test updates

Related Issues

Closes #962

Changes Made

Files Modified

  • app/layout.tsx — use bg-background and text-foreground on the body.
  • app/(dashboard)/layout.tsx — use the background token on the dashboard wrapper.
  • app/settings/language/page.tsx — replace fixed background and text colors with theme tokens.
  • app/globals.css — set dark theme background and foreground variables to the existing navy and pale text colors.
  • components/navbar/MobileBottomTabs.tsx, components/navbar/mobile-drawer.tsx, and components/patterns/DisputeActionPattern.tsx — replace remaining bg-[#060e20] classes with bg-background.
  • app/styles/themes/high-contrast.test.tsx — cover body token classes and background/foreground palette values for light, dark, and high-contrast themes.

Key Changes

  • Page surfaces now use CSS variables, allowing light and high-contrast themes to override them.
  • High-contrast mode uses its existing black background and white foreground palette.

Testing

  • Unit tests updated
  • Manual theme testing completed
  • Accessibility testing completed

Test Coverage

  • New theme assertions added
  • Existing tests confirmed passing

pnpm test app/styles could not complete because package downloads from the registry timed out.

Screenshots/Videos

Not included.

Pre-submission Checklist

Code Quality

  • Self-review completed
  • Linting and TypeScript checks completed

Functionality

  • All tests pass
  • No breaking changes intended

Documentation

  • No documentation changes required

Security & Accessibility

  • No sensitive data exposed
  • Accessibility contrast manually verified

Breaking Changes

Breaking Changes: None.

Migration Steps: None.

Additional Notes

No dependencies were added. The requested test run was blocked during dependency installation by registry timeouts.

Labels

bugfix, frontend, ui/ux

@vercel

vercel Bot commented Sep 28, 2026

Copy link
Copy Markdown

@Killerjunior is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Sep 28, 2026

Copy link
Copy Markdown

@Killerjunior Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@greatest0fallt1me
greatest0fallt1me merged commit fd01c83 into Predictify-org:main Sep 29, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let light and high-contrast themes override body colors

2 participants