Repository navigation
refactor(version): namespaceFromMajor, restes de la relecture de #112 - #114
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e ; test mort retiré de getCatalog Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rcer la majeure Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 5, 2026
PrestaEdit
added a commit
that referenced
this pull request
Oct 5, 2026
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restes de la relecture finale de #112 (version par instance). Aucun changement de comportement.
Version::namespaceFromMajor()(statique) devient la seule règle « majeure → namespace » :'1.7'→'7','1.6'→'6','8'et'9'inchangés.getMajorVersion(namespace: true)etImportPage::pageNamespaceVersion()l'utilisent ; le doublonsubstr($major, 2)disparaît.Translations::getCatalog: la condition mortegetMajorVersion() !== nullest retirée.getMajorVersion()renvoie toujours une chaîne ou lève une exception.VisualCheckpointTagTest:makePage()construit la page avec sonpatchVersionau lieu de forcer une majeure sur une page en 8.1.0. Les assertions de tag sont inchangées.Tests : 543 verts sous PHP 8.4 et 8.1 (un test ajouté pour
namespaceFromMajor).L'app ignore les méthodes statiques dans l'éditeur (
SuiteMetadata::methodsForClass) : la nouvelle méthode n'y apparaît pas.🤖 Generated with Claude Code