Skip to content

Prevent fatal error when product template variable is a Product object #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boo-code wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Prevent fatal error when product template variable is a Product object #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions classes/Hook/HookDisplayFooterProduct.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,14 @@ public function run()
return;
}

// The 'product' template variable is expected to be a ProductLazyArray (array-accessible).
// Some themes or modules assign a raw Product object instead, which prepareItemFromProduct()
// cannot consume (it accesses array keys) and would raise a fatal error on the product page.
// Skip tracking in that case rather than breaking the page.
if (!is_array($product) && !$product instanceof \ArrayAccess) {
return;
}

// Initialize tag handler
$gaTagHandler = new GanalyticsJsHandler($this->module, $this->context);

Expand Down
Loading