Skip to content

CI: pin PrestaShop 9.1.5 and add 9.2.x to the PHPStan matrix #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jolelievre merged 2 commits into from
Aug 28, 2026
Merged

CI: pin PrestaShop 9.1.5 and add 9.2.x to the PHPStan matrix #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db22afc
CI: pin PrestaShop 9.1.5 instead of the superseded 9.1.4 tag
mattgoud Aug 27, 2026
f55375f
CI: add PrestaShop 9.2.x to the PHPStan matrix
mattgoud Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,11 @@ jobs:
# PrestaShop 9.0.x supports PHP 8.1 up to 8.4 (8.5 is not supported)
- { presta_version: '9.0.3', php_version: '8.1' }
- { presta_version: '9.0.3', php_version: '8.4' }
# PrestaShop 9.1.x and develop support PHP 8.1 up to 8.5
- { presta_version: '9.1.4', php_version: '8.1' }
- { presta_version: '9.1.4', php_version: '8.5' }
# PrestaShop 9.1.5, 9.2.x and develop support PHP 8.1 up to 8.5
- { presta_version: '9.1.5', php_version: '8.1' }
- { presta_version: '9.1.5', php_version: '8.5' }
- { presta_version: '9.2.x', php_version: '8.1' }
- { presta_version: '9.2.x', php_version: '8.5' }
- { presta_version: 'develop', php_version: '8.1' }
- { presta_version: 'develop', php_version: '8.5' }
fail-fast: false
Expand Down
0 tests/php/phpstan/phpstan-9.1.4.neon → tests/php/phpstan/phpstan-9.1.5.neon
View file
Open in desktop
File renamed without changes.
15 changes: 15 additions & 0 deletions tests/php/phpstan/phpstan-9.2.x.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
includes:
- %currentWorkingDirectory%/tests/php/phpstan/phpstan.neon

parameters:
ignoreErrors:
# Framework / structural limitations that cannot be fixed in module code:
# - uninstallModule() calls parent::uninstall() through a closure rebound to the
# target module via Closure::bindTo(), a pattern PHPStan cannot statically resolve.
# - Cookie uses magic __get/__set, so its dynamic properties are undefined to PHPStan.
# - HookInterface mandates the constructor signature (Ps_Googleanalytics $module, Context),
# so $module must be stored even in hooks that never read it back.
- '#PrestaShop\\Module\\Ps_Googleanalytics\\Handler\\ModuleHandler::uninstallModule\(\) calls parent::uninstall\(\) but PrestaShop\\Module\\Ps_Googleanalytics\\Handler\\ModuleHandler does not extend any class.#'
- '#Access to an undefined property Cookie\:\:\$ga_admin_order.#'
- '#Access to an undefined property Cookie\:\:\$ga_admin_refund.#'
- '#Property PrestaShop\\Module\\Ps_Googleanalytics\\Hooks\\HookActionValidateOrder::\$module is never read, only written\.#'
Loading